Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate test fixtures #1137

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Conversation

facutuesca
Copy link
Collaborator

Follow up to #1124 (comment). Move the common fixtures to test/conftest.py, and use test/unit/conftest.py and test/integration/cli/conftest.py for the unit/integration-specific fixtures.

cc @woodruffw

Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
@jku
Copy link
Member

jku commented Sep 23, 2024

/gcbrun

@woodruffw
Copy link
Member

/gcbrun

Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @facutuesca!

@woodruffw woodruffw merged commit 47e8359 into sigstore:main Sep 24, 2024
25 checks passed
@woodruffw woodruffw deleted the reorganise-tests branch September 24, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants